Repository navigation
build(deps): bump kube to 4.2, k8s-openapi to 0.28, and k8s-controller to 0.14 - #39355
Merged
Merged
Conversation
This was referenced Oct 3, 2026
…r to 0.14 kube 4 builds CRDs as typed `CustomResourceDefinition`s, which omit the empty `spec.names.categories` list, so the exported VpcEndpoint CRD changes accordingly. k8s-controller exposes kube types, and 0.14 is its first release on kube 4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
antiguru
changed the title
antiguru
marked this pull request as ready for review
October 14, 2026 10:18
alex-hunt-materialize
previously approved these changes
Oct 14, 2026
alex-hunt-materialize
dismissed
their stale review
October 14, 2026 10:37
Waiting on orchestratord tests.
Alphadelta14
approved these changes
Oct 14, 2026
Member
Author
|
Thanks for the reviews! |
antiguru
added a commit
that referenced
this pull request
Oct 15, 2026
`serde_yaml` is deprecated, and it depends on the unmaintained `unsafe-libyaml` (RUSTSEC-2024-0449). `mz-debug` and `mz-metrics-catalog` only write YAML, so this PR moves both to `serde-saphyr`, built with only its `serialize` feature. `kube-client` already depends on `serde-saphyr` since #39355. With `serde_yaml` gone, `unsafe-libyaml` leaves the dependency tree, and its advisory ignore in `deny.toml` goes with it. The PR also regenerates `doc/user/data/metrics.yml`. Its content is unchanged: all 799 entries parse to the same data as before. The formatting differs in two ways. Quoted names use double quotes instead of single quotes, and long help strings become folded block scalars. YAML that `mz-debug` writes for Kubernetes objects changes in the same ways. It also drops the ignores for RUSTSEC-2026-0173 and RUSTSEC-2026-0253, which `cargo deny` no longer detects on main. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace compiles unchanged against kube 4.2 and k8s-openapi 0.28, and it keeps the
v1_34API feature. k8s-controller moves to 0.14, its first release on kube 4.kube 4 builds derived CRDs as typed
CustomResourceDefinitions, which omit the emptyspec.names.categorieslist. The exported VpcEndpoint CRD changes by that field. Kubernetes treats an absent list and an empty one the same.Other kube 4 behavior changes that reach us:
mz_orchestrator_kubernetes::util::create_clientsetsread_timeoutandconnect_timeoutexplicitly, so our clients keep their timeouts.hyper-util-tracing, which this PR does not enable.smallvec < 1.16. The lock moves smallvec from 1.16.2 back to 1.15.2, which still satisfies the workspace requirement of 1.15.1.kube-client 4 replaces
serde_yamlwithserde-saphyr.RUSTSEC-2024-0449(unsafe-libyaml) stays ignored becausemz-debugandmz-metrics-cataloguseserde_yamldirectly, and thedeny.tomlcomment now says so.Posted by Claude Code.
🤖 Generated with Claude Code